Auto tick yes/no comments in subroutine

Collapse
X
 
  • Filter
  • Time
  • Show
Clear All
new posts
    A-machine-insp
    PC-DMIS demi-Guru

  • A-machine-insp
    commented on 's reply
    Originally posted by Kp61dude! View Post
    I don't want to work today but here I am.
    Ditto.....

  • GEO3D
    commented on 's reply
    Yes I think they are looking for the least effort possible. I've actually got it set so that the job number, part number then pass or fail will save into the file name, it then uses the job number to print to the correct folder, then you can see if it's a pass or fail without even opening the results. That's a good idea to set them to print to a good or bad folder I'll look into implementing that, the NG is also a good idea. Thanks for your advice Kp61dude

  • GEO3D
    commented on 's reply
    Thanks Kirbster another great idea.. Like I mentioned I haven't had much need to use flow control commands in all my years of programming, so your advice is very helpful. I think I was making it too hard for myself after seeing these methods
    Last edited by GEO3D; 06-27-2019, 04:30 PM.
  • KIRBSTER269
    PC-DMIS Guru

  • KIRBSTER269
    commented on 's reply
    Hey no problem, but I think in this instance, the IF/GOTO would have worked better in your favor Then the END_IF/, but glad anders solution was the better choice
  • Kp61dude!
    PC-DMIS demi-Guru

  • Kp61dude!
    replied
    They don't want to read the report? I don't want to work today but here I am. Just joking. Create output folders for good reports and bad reports. I feel what they mean by having to look at all the reports, for me when I was running 1000pc lot 24pcs at a time... it got really old really fast. Also, add an "NG" for the report file name, again just little visual ques to speed the process up.

    Leave a comment:


  • GEO3D
    commented on 's reply
    Haha, yes I did notice that Andersl. I've tested it offline so made the dimension out of tolerance and noticed it was back to front and changed it round.. I know where the PAPP report is but never thought to use it, in this istance it's a great idea.. Thanks again Andersl.

  • GEO3D
    commented on 's reply
    Hi Kirbster, I was trying that just recently. I had wrote the comment twice, one saying yes and the other saying no, I was trying to use END_IF command and filter either with the tolerance. Labels definitely sounds like a better way though but I've succesfully used Andesrl method and it works perfect. Thanks for taking the time to help Kirbster.
  • AndersI
    PC-DMIS Guru

  • AndersI
    commented on 's reply
    Do note that I got the YES and NO backwards in that quickie. And may I suggest you show your customer the PPAP report - with nice red stop signs or green check marks. Already prepared for you by PC-DMIS...

  • GEO3D
    commented on 's reply
    Hi Andersl, that is genius.. Kirbster is right, this program was written a few years ago and we are currently running them 1 at a time, we initially supplied the results as PC-DMIS reports but they weren't happy at having to read through them, so they insisted we had comments stating yes or no at the end of the report. It sounds silly looking back on it but we obliged. It is a quick program to run and is manned for every part so it wasn't an issue to do it that way at the time.

    I am getting better at variables and coding (never had to use them a lot) and being busy back then without this know how it was an easy fix, then it was on to the next problem. I've just recently had the time ro revisit the process and as the post states I have it running as 8 parts on a subroutine program which is abviously going to improve the process. I appreciate your input, many thanks this will help a lot.
    Last edited by GEO3D; 06-27-2019, 11:30 AM.
  • KIRBSTER269
    PC-DMIS Guru

  • KIRBSTER269
    commented on 's reply
    Even better +1. That might be customers goofy request. That makes them feel secure that you're watching the parts all the time. Not my thinking, theirs. I have had goofy request like this crap myself.
  • KIRBSTER269
    PC-DMIS Guru

  • KIRBSTER269
    replied
    It would be along way around, but I believe if you make 2 comments asking about the Same thing, but rewording it to answer YES, but using variables to ask the right question, I believe it could be done. For instance one the YES and NO

    MAKE assignments if your tolerance is <, =,> then go to a label and it would answer that question.

    GOOD_PART_LABEL

    "IS THE FEATURE GOOD" YES/NO

    BAD_PART_LABEL

    "IS THE FEATURE BAD" YES/NO

    It can be done I just don't have a quick answer for you

    Leave a comment:

  • AndersI
    PC-DMIS Guru

  • AndersI
    replied
    If you have an evaluated dimension, why on Earth would you also post a question to the operator? That you don't want him to answer? Just set a variable to "YES" or "NO" and report that variable. You could even forego the variable, and have the expression IF(..,..,..) directly in the COMMENT/REPT

    Code:
               ASSIGN/V_YN=IF(SHT2D2_0_505_1.Z.OUTTOL, [COLOR=#FF0000]"YES", "NO"[/COLOR])
               COMMENT/REPT,
               "SHT2D2_0_505_1.Z - " + V_YN
    Edit: Reverse the order of YES and NO in the code above - I got it backwards.
    AndersI
    PC-DMIS Guru
    Last edited by AndersI; 06-27-2019, 11:20 AM.

    Leave a comment:


  • GEO3D
    commented on 's reply
    Thanks Kirbster, I was actually hoping that it would only tick yes if the feature in question was in tolerance in the program, but tick no if not in tolerance and show up in the report as such. Not sure it can be done, unless there is another way.. Thanks again for your input.
  • KIRBSTER269
    PC-DMIS Guru

  • KIRBSTER269
    commented on 's reply
    oops take that back your looking for it to auto YES for good numbers and No for bad?
  • KIRBSTER269
    PC-DMIS Guru

  • KIRBSTER269
    replied
    Make a Check mark and at least put 1 second for a time and this will automatically say YES without clicking anything.

    Capture.JPG

    Leave a comment:

Related Topics

Collapse

Working...
X