High Point Extraction ?

**craiger_ny** · 11-30-2006, 09:01 AM

Wouldn't you want your first MAXVAL declaration to equal 0? If not then any hit with a measured value of less than 1 will fail your conditional statement where you evaluate MYVAL > MAXVAL. For positive or negative it will evaluate the number as is so using zero would not work for esclusively negative numbers. I'll need to look at it and think about it a bit.

**Don Ruggieri** · 11-30-2006, 09:02 AM

Maxval

Your Z values are all less than '1' which is your initial Max Value. Set your initial MaxVal to -9999

**craiger_ny** · 11-30-2006, 09:04 AM

WDS use a reduculously negative number.

**drako28** · 11-30-2006, 09:22 AM

Thanks for the help guy's. Still having the same problem. It's only reporting the first scan point.

**Don Ruggieri** · 11-30-2006, 10:26 AM

try some debug

I don't have a scan handy to try this out right now, but whenever this sort of thing happens to me, I throw in some debug to see what is happening inside. For example -

ASSIGN/NHITS = SCN1.NUMHITS
ASSIGN/C = 1
ASSIGN/MAXVAL = 1
DO/
ASSIGN/MYVAL = SCN1.HIT[C].Z

Comment/Oper, Myval
Comment/Oper, Maxval
Comment/Oper, C

IF/MYVAL>MAXVAL
ASSIGN/MAXVAL = MYVAL
ASSIGN/HITN = C
END_IF/
ASSIGN/C = C+1
UNTIL/C==NHITS

This will help determine that the values you intend are actually being used or not. Perhaps it is using a wrong value somewhere?

**Don Ruggieri** · 11-30-2006, 10:36 AM

works for me

I was on hold, so I made a scan off-line and tried your code. It worked for me.

Compare mine -

ASSIGN/NHITS = SCN1.NUMHITS
ASSIGN/C = 1
ASSIGN/MAXVAL = -9999
DO/
ASSIGN/MYVAL = SCN1.HIT[C].Z
IF/MYVAL>MAXVAL
ASSIGN/MAXVAL = MYVAL
ASSIGN/HITN = C
END_IF/
ASSIGN/C = C+1
UNTIL/C==NHITS
COMMENT/OPER,NO,MAXVAL
COMMENT/OPER,NO,C

to yours and see if there is any syntax difference. I could not see any. Sometimes, I found that if the debug test (mentioned earlier) does not display the proper values, you may only need to re-type the variable name to force it to re-think it.

**craiger_ny** · 11-30-2006, 10:43 AM

I mentioned in a PM too that sometimes PCDMIS does not recognize variables. If the syntax matches he might want to try retyping in his variable names or renaming especially the variable C. Sometimes for whatever reason it will see them and sometimes not it's a sure thing that it sees it when you type it in and PCDMIS asks if what you typed is a reference to a variable. Thanks for the debug I was going to do that when I had a chance I had a feeling it would work. Perhaps he could insert comments with each variable referenced to see which ones return what.

Craig

**cmmguy** · 11-30-2006, 10:47 AM

Why do you do this step:
ASSIGN/MYVAL = SCN1.HIT[C].Z
instead of just comparing directly?

**drako28** · 11-30-2006, 11:02 AM

How do you compare directly?

**cmmguy** · 11-30-2006, 11:05 AM

Instead of this:
ASSIGN/MYVAL = SCN1.HIT[C].Z
IF/MYVAL>MAXVAL
ASSIGN/MAXVAL = MYVAL

can you do this:
IF/SCN1.HIT[C].Z>MAXVAL
ASSIGN/MAXVAL = SCN1.HIT[C].Z

**drako28** · 11-30-2006, 11:18 AM

Worked great. My problem is now when I try making a generic point. It's only reporting the first scan point of the scan. Not the one I need.

**craiger_ny** · 11-30-2006, 11:20 AM

Try using the variable you assigned the max value to inside the generic feature instead of the varaible with the hit number, that will simplify it. I may not be understanding exactly what needs to be reported though, just the max hit value or is this where you need all of the info regarding that hit?

Craig

**drako28** · 11-30-2006, 12:07 PM

I need all the info regarding that hit.

**craiger_ny** · 11-30-2006, 12:19 PM

If you put HITN in a comment what does it return (you might be able to mouse hover too)?

High Point Extraction ?

High Point Extraction ?

Comment

Comment

Comment

Comment

Comment

Comment

Comment

Comment

Comment

Comment

Comment

Comment

Comment

Comment

Related Topics